Fixed bug #324 - prevent unaligned load access #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use memcpy so we can expect the compiler to optimize when possible
|
Can you check the disassembly and verify that this is actually turned into optimized instructions? |
|
yes, If I use SDL_memcopy, it adds SDL_memcpy calls. |
|
Tested and this indeed does fix the issue. Also, @slouken here's proof this compiles to identical assembly on x86: https://godbolt.org/z/aG1qnvn4o Note there are only differences at -O0, it gets optimized correctly at -O1 or higher. |
|
Merged to main and SDL2, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug #324 - prevent unaligned load access
use memcpy so we can expect the compiler to optimize when possible